Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker-compose.web.yml as base compose file #2360

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

wslulciuc
Copy link
Member

Problem

When the web UI is enabled running docker/up.sh, the Marquez HTTP server is not set correctly:

marquez-web-1               | [HPM] Proxy created: /api/v1  -> http://undefined:undefined/
marquez-web-1               | App listening on port 3000!

Solution

Use docker-compose.web.yml as base compose file, with overrides for dev set via docker-compose.web-dev.yml.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the docker label Jan 14, 2023
@wslulciuc wslulciuc enabled auto-merge (squash) January 14, 2023 00:26
@wslulciuc wslulciuc merged commit 5424cfd into main Jan 14, 2023
@wslulciuc wslulciuc deleted the bug/docker-up-web-ui-error branch January 14, 2023 00:31
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #2360 (2f4201c) into main (5cae3ff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2360   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1177     1177           
=========================================
  Files           222      222           
  Lines          5354     5354           
  Branches        429      429           
=========================================
  Hits           4108     4108           
  Misses          768      768           
  Partials        478      478           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants