Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define marquez.yml for API load test #2368

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Jan 19, 2023

Problem

PR #2047 updated the DB host in marquez.dev.yml needed for api-load-test.sh. The update in the config file was a breaking change as discussed in PR 2355

Solution

This PR generates a marquez.yml file used by api-load-test.sh to run the API load test. This PR also reverts the DB host update in marquez.dev.yml.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #2368 (c9fa07c) into main (6436ddc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2368   +/-   ##
=========================================
  Coverage     76.81%   76.81%           
  Complexity     1195     1195           
=========================================
  Files           226      226           
  Lines          5473     5473           
  Branches        443      443           
=========================================
  Hits           4204     4204           
  Misses          772      772           
  Partials        497      497           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc added the review Ready for review label Jan 19, 2023
@pawel-big-lebowski pawel-big-lebowski merged commit 7f546ed into main Jan 19, 2023
@pawel-big-lebowski pawel-big-lebowski deleted the bug/marquez.dev.yml-db-host branch January 19, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants