Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new script for stopping docker #2380

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

rossturk
Copy link
Collaborator

@rossturk rossturk commented Jan 26, 2023

Signed-off-by: Ross Turk ross@rossturk.com

Problem

When starting Docker with docker/up.sh -d and wanting to later stop the deployment, there is no clean way to do it.

Solution

This adds a docker/down.sh script that works similarly to up.sh, passing the proper arguments to docker-compose down. This is not earth-shattering.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Ross Turk <ross@rossturk.com>
@boring-cyborg boring-cyborg bot added the docker label Jan 26, 2023
Signed-off-by: Ross Turk <ross@rossturk.com>
@boring-cyborg boring-cyborg bot added the docs label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #2380 (b96c366) into main (c7c89df) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2380   +/-   ##
=========================================
  Coverage     76.81%   76.81%           
  Complexity     1195     1195           
=========================================
  Files           226      226           
  Lines          5473     5473           
  Branches        443      443           
=========================================
  Hits           4204     4204           
  Misses          772      772           
  Partials        497      497           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc merged commit 5e92e75 into MarquezProject:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants