Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Dataset Versions and Dataset types the same #2400

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Feb 3, 2023

Problem

Currently there is a difference between the typedefs for datasets vs dataset versions that is preventing type generating systems from treating them as the same.

Closes: #ISSUE-NUMBER

Solution

This PR makes the fields property the same between datasets and dataset versions.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the spec label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #2400 (41d985d) into main (d209bdd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2400   +/-   ##
=========================================
  Coverage     77.11%   77.11%           
  Complexity     1234     1234           
=========================================
  Files           228      228           
  Lines          5572     5572           
  Branches        447      447           
=========================================
  Hits           4297     4297           
  Misses          775      775           
  Partials        500      500           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phixMe phixMe marked this pull request as ready for review February 7, 2023 22:07
@phixMe phixMe requested a review from wslulciuc February 7, 2023 22:07
@wslulciuc wslulciuc enabled auto-merge (squash) February 8, 2023 00:09
@wslulciuc wslulciuc disabled auto-merge February 8, 2023 00:14
@wslulciuc wslulciuc merged commit bb411a9 into main Feb 8, 2023
@wslulciuc wslulciuc deleted the fix/api-spec-dataset-versions-dataset branch February 8, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants