Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include missing indexes #2419

Merged
merged 1 commit into from
Feb 14, 2023
Merged

include missing indexes #2419

merged 1 commit into from
Feb 14, 2023

Conversation

pawel-big-lebowski
Copy link
Collaborator

Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com

Problem

Some foreign key references columns are missing being indexed.

Closes: #2418

Solution

  • Add missing indexes.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added api API layer changes docs labels Feb 14, 2023
@pawel-big-lebowski pawel-big-lebowski force-pushed the fix/create-missing-indexes branch from 72665bb to 0eeb090 Compare February 14, 2023 10:34
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@pawel-big-lebowski pawel-big-lebowski force-pushed the fix/create-missing-indexes branch from 0eeb090 to 24820d8 Compare February 14, 2023 10:41
@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review February 14, 2023 10:43
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #2419 (24820d8) into main (aa1cfce) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2419   +/-   ##
=========================================
  Coverage     77.11%   77.11%           
  Complexity     1234     1234           
=========================================
  Files           228      228           
  Lines          5572     5572           
  Branches        447      447           
=========================================
  Hits           4297     4297           
  Misses          775      775           
  Partials        500      500           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit 0e434d5 into main Feb 14, 2023
@wslulciuc wslulciuc deleted the fix/create-missing-indexes branch February 14, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add indexes to column_lineage table
2 participants