Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix job update SQL to correctly use simple_name for job updates #2457

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix job update SQL to correctly use simple_name for job updates #2457

merged 1 commit into from
Mar 28, 2023

Conversation

collado-mike
Copy link
Collaborator

Problem

In #2448 we updated the job update logic to support adding a parent to an existing job. However, there was a bug in the update SQL that set the simple_name field to the fully qualified name instead. This fix addresses that bug and adds an assertion to the test that covers this case.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@collado-mike
Fix job update SQL to correctly use simple_name for job updates
acf300a 
Signed-off-by: Michael Collado <collado.mike@gmail.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Mar 27, 2023
wslulciuc
wslulciuc approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc enabled auto-merge (squash) March 27, 2023 22:17
@collado-mike collado-mike disabled auto-merge March 28, 2023 17:04
@collado-mike collado-mike merged commit ffc2ac7 into main Mar 28, 2023
@collado-mike collado-mike deleted the fix/job_update_simple_name branch March 28, 2023 17:04
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
@collado-mike
Fix job update SQL to correctly use simple_name for job updates (Marq…
90daf6b 
…uezProject#2457)

Signed-off-by: Michael Collado <collado.mike@gmail.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wslulciuc wslulciuc wslulciuc approved these changes

Assignees

@wslulciuc wslulciuc

Labels
api API layer changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@collado-mike @wslulciuc