Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip regex after postgresql in chart/values.yaml #2488

Merged
merged 1 commit into from
May 18, 2023

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented May 18, 2023

Problem

On a release, the tag for postgresql is bumped and set to the current version of Marquez.

Solution

Update regex for chart verson bump to find and replace occurrences of tag:.* in the file, but not modify lines after postgresql.

One-line summary:

Fix regex for version bump of chart/values.yaml in new-version.sh.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: wslulciuc <willy@datakin.com>
@wslulciuc wslulciuc requested a review from merobi-hub May 18, 2023 20:46
@wslulciuc wslulciuc added the review Ready for review label May 18, 2023
Copy link
Collaborator

@merobi-hub merobi-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@wslulciuc wslulciuc enabled auto-merge (squash) May 18, 2023 20:49
@wslulciuc wslulciuc merged commit ceab336 into main May 18, 2023
@wslulciuc wslulciuc deleted the bug/version-bump-helm-chart branch May 18, 2023 20:51
@wslulciuc wslulciuc mentioned this pull request May 18, 2023
7 tasks
@wslulciuc wslulciuc removed the review Ready for review label May 18, 2023
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
…2488)

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants