Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagination to datasets #2512

Merged
merged 9 commits into from
Jun 13, 2023
Merged

add pagination to datasets #2512

merged 9 commits into from
Jun 13, 2023

Conversation

merobi-hub
Copy link
Collaborator

Problem

Pagination would make viewing datasets in namespaces with many datasets more manageable, as in the case of events. But currently datasets are not paginated.

Solution

This paginates the datasets route in the same way events are paginated.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: adds pagination to datasets

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Michael Robinson <merobi@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Jun 12, 2023
@merobi-hub merobi-hub marked this pull request as draft June 12, 2023 17:55
@merobi-hub merobi-hub requested a review from phixMe June 12, 2023 17:55
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2512 (1f7fa8a) into main (b62cee3) will not change coverage.
The diff coverage is n/a.

❗ Current head 1f7fa8a differs from pull request most recent head 2071c90. Consider uploading reports for the commit 2071c90 to get more accurate results

@@            Coverage Diff            @@
##               main    #2512   +/-   ##
=========================================
  Coverage     83.80%   83.80%           
  Complexity     1233     1233           
=========================================
  Files           235      235           
  Lines          5625     5625           
  Branches        270      270           
=========================================
  Hits           4714     4714           
  Misses          767      767           
  Partials        144      144           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

page: 1,
pageIsLast: false
}
this.pageSize = 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would declare this as a const outside of the component like

const PAGE_SIZE = 20

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phixMe that fixed the issue. Thank you.

Signed-off-by: Michael Robinson <merobi@gmail.com>
@merobi-hub merobi-hub requested a review from phixMe June 12, 2023 19:15
@merobi-hub merobi-hub marked this pull request as ready for review June 12, 2023 19:16
merobi-hub and others added 3 commits June 12, 2023 15:17
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Michael Robinson <merobi@gmail.com>
@merobi-hub merobi-hub enabled auto-merge (squash) June 13, 2023 16:26
@merobi-hub merobi-hub merged commit a7cf7fb into main Jun 13, 2023
@merobi-hub merobi-hub deleted the web/paginate-datasets branch June 13, 2023 16:33
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
* add pagination to datasets

---------

Signed-off-by: Michael Robinson <merobi@gmail.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants