Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging on jobs and datasets #2614

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Paging on jobs and datasets #2614

merged 5 commits into from
Sep 14, 2023

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Sep 12, 2023

Problem

This adds paging to jobs and datasets just like we already have on the lineage events page.

image

image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2614 (3280c41) into main (d1d47e2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2614   +/-   ##
=========================================
  Coverage     83.31%   83.31%           
  Complexity     1289     1289           
=========================================
  Files           243      243           
  Lines          5940     5940           
  Branches        280      280           
=========================================
  Hits           4949     4949           
  Misses          844      844           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🥇

# Conflicts:
#	web/src/store/sagas/index.ts
@phixMe phixMe merged commit d0d35fa into main Sep 14, 2023
3 checks passed
@phixMe phixMe deleted the feature/paging-jobs-datasets branch September 14, 2023 00:15
@phixMe phixMe mentioned this pull request Sep 14, 2023
7 tasks
@davidsharp7 davidsharp7 mentioned this pull request Jul 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants