Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Docker Compose cmd in up to V2 #2644

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

merobi-hub
Copy link
Collaborator

@merobi-hub merobi-hub commented Oct 8, 2023

Problem

Docker Compose version 1 has been at EOL since this past June. Our docker compose up command in docker/up.sh is technically not compatible with version 2, even if Docker Desktop for Mac (or Docker for MacOS in general?) permits the incorrect format. On at least one Linux distro, however, the command fails to execute when version 2 is installed. Error output mentions only MIME-type issues, which is confusing and unhelpful, making the issue hard to diagnose. New users on Linux can potentially be blocked by this.

Solution

This upgrades the up command in docker/up.sh to version 2. This should be sufficient to migrate the project.

Closes: #2643

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: upgrades docker/up.sh to Docker Compose V2

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: merobi-hub <merobi@gmail.com>
@boring-cyborg boring-cyborg bot added the docker label Oct 8, 2023
@merobi-hub merobi-hub requested a review from wslulciuc October 8, 2023 21:20
@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 336fb30
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65231d1ced9df900088fc423

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #2644 (336fb30) into main (75da43c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2644   +/-   ##
=========================================
  Coverage     83.35%   83.35%           
  Complexity     1295     1295           
=========================================
  Files           244      244           
  Lines          5948     5948           
  Branches        279      279           
=========================================
  Hits           4958     4958           
  Misses          844      844           
  Partials        146      146           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit bd82ad1 into main Oct 12, 2023
6 checks passed
@wslulciuc wslulciuc deleted the docker/upgrade-compose branch October 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Compose V1 at EOL
2 participants