Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove maven-archiver dependency from java client #2695

Conversation

davidjgoss
Copy link
Contributor

Problem

The Java client has a dependency on maven-archiver, which can bring some transitive vulnerabilities.

This is a build tool only though and shouldn't go through as a transitive dependency to consumers of the client. Further, I can't see why it's needed - the api module doesn't have it, and if I remove it and do a build and publish to my local Maven repo, it works fine.

Solution

Remove the dependency from build.gradle.

If I'm wrong and this is needed, we could look instead at adding the dependency to publishing or buildScript to avoid consumers getting it unnecessarily.

One-line summary:
remove maven-archiver dependency from java client

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: David Goss <david.goss@matillion.com>
Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 2075acd
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6569bd05a7f6d20008d1de38

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08a2c9e) 84.08% compared to head (2075acd) 84.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2695   +/-   ##
=========================================
  Coverage     84.08%   84.08%           
  Complexity     1379     1379           
=========================================
  Files           248      248           
  Lines          6295     6295           
  Branches        286      286           
=========================================
  Hits           5293     5293           
  Misses          849      849           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The marquez-java lib. used to be in it's own repo and moved to a multi-module based repo a while back. I can't seem to find the exact commit (or PR) that introduced the maven-archiver lib. to the java client, so it's cool by me to remove 👍

@wslulciuc wslulciuc merged commit d5efdae into MarquezProject:main Dec 1, 2023
16 checks passed
@davidjgoss davidjgoss deleted the fix/remove-maven-archiver-dependency branch December 1, 2023 17:54
yanlibert pushed a commit to libertyann/marquez that referenced this pull request Dec 7, 2023
Signed-off-by: David Goss <david.goss@matillion.com>
Signed-off-by: yanlibert <yannick.libert@gmail.com>
yanlibert pushed a commit to libertyann/marquez that referenced this pull request Dec 8, 2023
Signed-off-by: David Goss <david.goss@matillion.com>
@wslulciuc wslulciuc added this to the 0.43.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants