Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags API tests and class BaseResourceIntegrationTest #2700

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Dec 11, 2023

This PR adds an integration test suite for class TagResource and the base class BaseResourceIntegrationTest to be used when writing resource integration test.

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Dec 11, 2023
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 3346a0f
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65778121abf5cc0008629fb8

Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Signed-off-by: wslulciuc <willy@datakin.com>
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79ec777) 84.08% compared to head (3346a0f) 84.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2700   +/-   ##
=========================================
  Coverage     84.08%   84.08%           
  Complexity     1379     1379           
=========================================
  Files           248      248           
  Lines          6295     6295           
  Branches        286      286           
=========================================
  Hits           5293     5293           
  Misses          849      849           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc added the review Ready for review label Dec 11, 2023
@wslulciuc wslulciuc merged commit a5a0e55 into main Dec 12, 2023
16 checks passed
@wslulciuc wslulciuc deleted the feature/tests-for-tags branch December 12, 2023 09:38
@wslulciuc wslulciuc added this to the 0.43.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes review Ready for review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants