Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken lineage for repeated runs #2710

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

pawel-big-lebowski
Copy link
Collaborator

Problem

Repeated runs may cause broken lineage graph since recent release.

Closes: #2708

Solution

Write failing test & fix this.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added api API layer changes docs labels Dec 20, 2023
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit d57ea4e
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6582b9ae355d560008cf3410

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83608bb) 84.31% compared to head (d57ea4e) 84.34%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2710      +/-   ##
============================================
+ Coverage     84.31%   84.34%   +0.03%     
- Complexity     1413     1414       +1     
============================================
  Files           251      251              
  Lines          6402     6402              
  Branches        291      291              
============================================
+ Hits           5398     5400       +2     
+ Misses          851      850       -1     
+ Partials        153      152       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawel-big-lebowski pawel-big-lebowski force-pushed the fix-current-job_version branch 2 times, most recently from 323e78c to e4352b7 Compare December 20, 2023 09:22
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review December 20, 2023 10:06
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@wslulciuc wslulciuc merged commit 40d51f1 into main Dec 20, 2023
16 checks passed
@wslulciuc wslulciuc deleted the fix-current-job_version branch December 20, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken LineageGraph in 0.43.0
2 participants