Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset tag reducers bug #2716

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Dec 31, 2023

Problem

PR #2714 introduced the ability to add tags to a dataset.

Looks like the reducer was not done correctly and its interfering with the datasets route on the side bar after a dataset tag update.

Closes: #2715

Solution

remove result from dataset tags reducer

One-line summary:

remove result from dataset tags reducer to fix sidebar bug

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <number6labs@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Dec 31, 2023
Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 09dbf10
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6591e73af9ee9c0008e2cbe1

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04fc7b7) 84.42% compared to head (09dbf10) 84.42%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2716   +/-   ##
=========================================
  Coverage     84.42%   84.42%           
  Complexity     1416     1416           
=========================================
  Files           251      251           
  Lines          6434     6434           
  Branches        291      291           
=========================================
  Hits           5432     5432           
  Misses          850      850           
  Partials        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc merged commit cbc8e74 into MarquezProject:main Jan 1, 2024
16 checks passed
@davidsharp7 davidsharp7 deleted the bug/fix_tags_reducer branch January 1, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasets sidebar is failing after tag update
2 participants