-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset field level tags to UI #2729
Add dataset field level tags to UI #2729
Conversation
Signed-off-by: sharpd <number6labs@gmail.com>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
=========================================
Coverage 84.45% 84.45%
Complexity 1416 1416
=========================================
Files 251 251
Lines 6447 6447
Branches 291 291
=========================================
Hits 5445 5445
Misses 850 850
Partials 152 152 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sharpd <number6labs@gmail.com>
Signed-off-by: sharpd <number6labs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯, but let's also get a +1 from @phixMe
const handleOpen = (key: string) => { | ||
setOpen(true) | ||
setSelectedKey(key) | ||
localStorage.setItem(`dsi_${dsNamespace}_${dsName}`, JSON.stringify(newExpandedRows)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of want to get away from doing this because it doesn't move across urls. Could we possibly use use parameters for functionality like this?
</Collapse> | ||
</TableCell> | ||
</TableRow> | ||
</React.Fragment> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UI perspective, I think it may be perhaps better to have tags that are already part of a dataset listed.
For new tags, I think a dialog would be pretty nice for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: sharpd <number6labs@gmail.com>
Signed-off-by: sharpd <number6labs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidsharp7 This looks good now. We're going to have a merge conflict with the larger changes across the board, I may want to hold off merging this unless you need it immediately.
Cool, cool - No giant rush from me @phixMe @wslulciuc . |
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
Signed-off-by: sharpd <davidsharp7@gmail.com>
Problem
Currently the UI has no ability to add and delete tags at the field level. The proposed solution is update the DatasetTags component to allow for field level tagging/deletion and add this to the DatasetInfo component.
Closes: #2728
Solution
Update DatasetTags to include field level tagging in the UI.
One-line summary:
Update DatasetTags to include field level tagging in the UI
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)