Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make db port configurable via POSTGRES_PORT #2751

Merged
merged 12 commits into from
May 22, 2024
Merged

Make db port configurable via POSTGRES_PORT #2751

merged 12 commits into from
May 22, 2024

Conversation

merobi-hub
Copy link
Collaborator

@merobi-hub merobi-hub commented Feb 20, 2024

Problem

Currently, changing the db port requires modifying several different yml files in the project related to the Docker configuration.

Solution

This makes configuring the db port more developer-friendly by replacing the db port assignments with the existing env var, POSTGRES_PORT. It is given a default value of 5432 in up.sh.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: reconfigure docker compose to support easy db port reassignment

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 6aa5a5e
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/664d582fa0c05d00088eaf1e

@merobi-hub merobi-hub marked this pull request as draft February 20, 2024 17:17
@merobi-hub merobi-hub marked this pull request as ready for review February 20, 2024 17:55
Signed-off-by: merobi-hub <merobi@gmail.com>
@merobi-hub merobi-hub marked this pull request as draft February 20, 2024 21:51
@merobi-hub merobi-hub changed the title Make db port configurable via new env var Make db port configurable via POSTGRES_PORT Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87dcdf6) 80.63% compared to head (ff2d297) 84.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2751      +/-   ##
============================================
+ Coverage     80.63%   84.45%   +3.82%     
- Complexity      234     1416    +1182     
============================================
  Files            43      251     +208     
  Lines           976     6447    +5471     
  Branches         38      291     +253     
============================================
+ Hits            787     5445    +4658     
- Misses          160      850     +690     
- Partials         29      152     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: merobi-hub <merobi@gmail.com>
merobi-hub and others added 4 commits February 23, 2024 16:17
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
@wslulciuc wslulciuc marked this pull request as ready for review May 7, 2024 16:00
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@wslulciuc wslulciuc enabled auto-merge (squash) May 7, 2024 16:02
merobi-hub and others added 3 commits May 21, 2024 14:15
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
@boring-cyborg boring-cyborg bot added the docs label May 21, 2024
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
Signed-off-by: merobi-hub <merobi@gmail.com>
@wslulciuc wslulciuc merged commit 465ecaa into main May 22, 2024
15 checks passed
@wslulciuc wslulciuc deleted the docker/db-port branch May 22, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants