-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serviceAccount and extraContainers to helm chart values #2766
feat: serviceAccount and extraContainers to helm chart values #2766
Conversation
…alues Signed-off-by: Kostas Theo <ktheo@protonmail.com>
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
@wslulciuc - Hi there :) Not sure but looks like the unit test was cancelled? Not changing any code here which impacts on tests. How should I proceed? |
chart/README.md
Outdated
@@ -65,6 +66,7 @@ helm delete marquez | |||
| `marquez.resources.limits` | K8s resource limit overrides | `nil` | | |||
| `marquez.resources.requests` | K8s resource requests overrides | `nil` | | |||
| `marquez.podAnnotations` | Additional pod annotations for Marquez | `{}` | | |||
| `marquez.extraContaiers` | Additional container definitions to include inside Marquez Pod | `[]` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Typo extraContaiers
-> extraContainers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
=========================================
Coverage 84.47% 84.47%
Complexity 1429 1429
=========================================
Files 251 251
Lines 6460 6460
Branches 299 299
=========================================
Hits 5457 5457
Misses 850 850
Partials 153 153 ☔ View full report in Codecov by Sentry. |
@kostas-theo, I've fixed the CI for your PR (see #2769) and left a minor typo comment; looks good to merge otherwise! |
…eo/marquez into helm-cloud-flexibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 🥇
Great job! Congrats on your first merged pull request in the Marquez project! |
Problem
default
. This should ideally be configurable.Solution
Added the values
marquez.serviceAccount
andmarquez.extraContaiers
to the helm chart values, with defaults set which maintain the current functionality.One-line summary: serviceAccount and extraContaiers to helm chart values
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)