Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serviceAccount and extraContainers to helm chart values #2766

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

kostas-theo
Copy link
Contributor

Problem

  • The helm chart doesn't allow for using my own Kubernetes service account, implicitly using default. This should ideally be configurable.
  • The helm chart doesn't allow for passing in extra containers into the Kubernetes deployment for marquez which open up various deployment customization options (in my case for using google's cloud-sql-proxy container image for Cloud SQL auth).

Solution

Added the values marquez.serviceAccount and marquez.extraContaiers to the helm chart values, with defaults set which maintain the current functionality.

One-line summary: serviceAccount and extraContaiers to helm chart values

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

…alues

Signed-off-by: Kostas Theo <ktheo@protonmail.com>
Copy link

boring-cyborg bot commented Mar 12, 2024

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit a559257
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/65fa292861264300081d8cfd

@kostas-theo
Copy link
Contributor Author

@wslulciuc - Hi there :) Not sure but looks like the unit test was cancelled? Not changing any code here which impacts on tests. How should I proceed?

chart/README.md Outdated
@@ -65,6 +66,7 @@ helm delete marquez
| `marquez.resources.limits` | K8s resource limit overrides | `nil` |
| `marquez.resources.requests` | K8s resource requests overrides | `nil` |
| `marquez.podAnnotations` | Additional pod annotations for Marquez | `{}` |
| `marquez.extraContaiers` | Additional container definitions to include inside Marquez Pod | `[]` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Typo extraContaiers -> extraContainers

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (0e45fe0) to head (a559257).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2766   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc
Copy link
Member

wslulciuc commented Mar 15, 2024

@kostas-theo, I've fixed the CI for your PR (see #2769) and left a minor typo comment; looks good to merge otherwise!

@kostas-theo kostas-theo requested a review from wslulciuc March 20, 2024 00:47
@kostas-theo kostas-theo changed the title feat: serviceAccount and extraContaiers to helm chart values feat: serviceAccount and extraContainers to helm chart values Mar 20, 2024
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🥇

@wslulciuc wslulciuc merged commit 13b6fbb into MarquezProject:main Mar 21, 2024
15 checks passed
Copy link

boring-cyborg bot commented Mar 21, 2024

Great job! Congrats on your first merged pull request in the Marquez project!

@wslulciuc wslulciuc added this to the 0.47.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants