Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring dataset tags into line with Job Tags #2841

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

davidsharp7
Copy link
Member

@davidsharp7 davidsharp7 commented Jun 24, 2024

Problem

The "Edit Tags" dialog is different between Job Tags and Dataset tags. The Show Field Tags Label also could be smaller to look better.

Solution

Bring datasets tags into line with Job Tags and make the Show Field tags switch label smaller.
Screenshot 2024-06-24 at 21 38 43
Screenshot 2024-06-24 at 21 38 06

One-line summary:

bring dataset tags into line with job tags.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: sharpd <davidsharp7@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 23b9d1b
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66793fdbdd8f0d0008718c18

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (66e2d7a) to head (23b9d1b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2841   +/-   ##
=========================================
  Coverage     84.74%   84.74%           
  Complexity     1456     1456           
=========================================
  Files           253      253           
  Lines          6562     6562           
  Branches        305      305           
=========================================
  Hits           5561     5561           
  Misses          850      850           
  Partials        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the followup!

@phixMe phixMe merged commit b5bcfbf into main Jun 24, 2024
16 checks passed
@phixMe phixMe deleted the web/update_dataset_tags branch June 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants