Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup issues highlighted by some Spark Integration Data #2856

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Jul 19, 2024

Problem

Fixes numerous issues in our interfaces related to some OpenLineage Spark events.

  • Long Names
  • Source Code facet null checking
  • ID parity across jobs and datasets.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Jul 19, 2024
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 129d942
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/669acb9957478b00082a5811

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (fcfebc5) to head (129d942).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2856   +/-   ##
=========================================
  Coverage     84.74%   84.74%           
  Complexity     1456     1456           
=========================================
  Files           253      253           
  Lines          6562     6562           
  Branches        305      305           
=========================================
  Hits           5561     5561           
  Misses          850      850           
  Partials        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davidsharp7 davidsharp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phixMe - yeah looks good to me.

@phixMe phixMe merged commit 2523965 into main Jul 20, 2024
17 checks passed
@phixMe phixMe deleted the feature/spark-data-cleanup branch July 20, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants