[FIX] Dataset query to get only the latest facet for each version #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
sophiely
force-pushed
the
feat/fix-find-all-dataset-query
branch
from
4470982 to
676800d
Compare
Signed-off-by: sophiely <ly.sophie200@gmail.com>
Signed-off-by: sophiely <ly.sophie200@gmail.com>
sophiely
force-pushed
the
feat/fix-find-all-dataset-query
branch
from
3e05cdd to
2e76688
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
=========================================
Coverage 84.75% 84.75%
Complexity 1456 1456
=========================================
Files 253 253
Lines 6566 6566
Branches 305 305
=========================================
Hits 5565 5565
Misses 850 850
Partials 151 151 ☔ View full report in Codecov by Sentry. |
phixMe
approved these changes
Jul 25, 2024
wslulciuc
reviewed
Jul 25, 2024
| df.facet, | ||
| df."name", | ||
| df.created_at, | ||
| rank() OVER (PARTITION BY df.dataset_version_uuid, "name" |
For now i don't think so but ofc I will let you know if I notice similar issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes: #2860
Solution
Since the same facet type is replicated a lot of times, we can rank the facet partition by dataset version and facet name ands so as we can take only the most recent facet for each dataset uuid and type.
The UI seems to display only one facet per type (facet name) and dataset version anyway so we don't need to query as much facet (which are just duplicates anyway).
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)