-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parent job in job panel #2868
Parent job in job panel #2868
Conversation
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 1470 1470
=========================================
Files 256 256
Lines 6626 6626
Branches 308 308
=========================================
Hits 5617 5617
Misses 856 856
Partials 153 153 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, but otherwise great to see the quick turn around on getting parent job metadata displayed 💯 💯 💯
* Adding parent job from query update. * Formatting and tooltip added. * None --> N/A Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
Problem
Due to the update from #2752 we now have the
parentJobName
available to us. We now display that in our job panel if it's avaialble. Also added was the job type to even out the metadata that we display.Solution
Simple rendering and type adjustment to accomidate the new field available.
One-line summary:
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)