Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent job in job panel #2868

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Parent job in job panel #2868

merged 4 commits into from
Aug 8, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Aug 6, 2024

Problem

Due to the update from #2752 we now have the parentJobName available to us. We now display that in our job panel if it's avaialble. Also added was the job type to even out the metadata that we display.

Note Type and Parent Job now available:
image

Solution

Simple rendering and type adjustment to accomidate the new field available.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@phixMe phixMe requested a review from wslulciuc August 6, 2024 17:34
@phixMe phixMe added the web label Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit af90305
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66b50e24ebe36a00088341c0

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (2594958) to head (dd34c80).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2868   +/-   ##
=========================================
  Coverage     84.77%   84.77%           
  Complexity     1470     1470           
=========================================
  Files           256      256           
  Lines          6626     6626           
  Branches        308      308           
=========================================
  Hits           5617     5617           
  Misses          856      856           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but otherwise great to see the quick turn around on getting parent job metadata displayed 💯 💯 💯

@phixMe phixMe changed the title feature/adding-parent-job Parent job in job panel Aug 7, 2024
@phixMe phixMe enabled auto-merge (squash) August 7, 2024 20:31
@phixMe phixMe merged commit 9ab3d45 into main Aug 8, 2024
15 checks passed
@phixMe phixMe deleted the feature/adding-parent-job branch August 8, 2024 18:36
alaturqua pushed a commit to alaturqua/marquez that referenced this pull request Aug 21, 2024
* Adding parent job from query update.

* Formatting and tooltip added.

* None --> N/A

Signed-off-by: Isa Inalcik <isa.inalcik@gmail.com>
@wslulciuc wslulciuc added this to the 0.50.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants