Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/404-page #2890

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feature/404-page #2890

merged 1 commit into from
Sep 4, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Sep 3, 2024

Problem

We're missing a basic catch all 404 page and this adds it.

image

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 7c9c736
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66d7781603a87700087b5db4

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (66329d1) to head (7c9c736).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2890   +/-   ##
=========================================
  Coverage     83.25%   83.25%           
  Complexity     1476     1476           
=========================================
  Files           259      259           
  Lines          6785     6785           
  Branches        313      313           
=========================================
  Hits           5649     5649           
  Misses          981      981           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc merged commit a586a89 into main Sep 4, 2024
16 checks passed
@wslulciuc wslulciuc deleted the feature/404-page branch September 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants