Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated event count chip rendering #2916

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

NisargChokshi45
Copy link
Contributor

Problem

👋 Thanks for opening a pull request! Please include a brief summary of the problem your change is trying to solve, or bug fix. If your change fixes a bug or you'd like to provide context on why you're making the change, please link the issue as follows:

Closes: #ISSUE-NUMBER

Solution

Please describe your change as it relates to the problem, or bug fix, as well as any dependencies. If your change requires a database schema migration, please describe the schema modification(s) and whether it's a backwards-incompatible or backwards-compatible change.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: Updated event count chip rendering

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Oct 3, 2024
Copy link

boring-cyborg bot commented Oct 3, 2024

Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md).

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 6ee3286
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66fed97d3b232b0008a018d4

@NisargChokshi45
Copy link
Contributor Author

Hey @wslulciuc @phixMe, can you please review this PR ?
If possible, can we also add a label named hacktoberfest in the PR ?

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (9e8e3d3) to head (6ee3286).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2916   +/-   ##
=========================================
  Coverage     83.10%   83.10%           
  Complexity     1487     1487           
=========================================
  Files           264      264           
  Lines          6849     6849           
  Branches        315      315           
=========================================
  Hits           5692     5692           
  Misses         1002     1002           
  Partials        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc requested a review from phixMe October 3, 2024 19:07
@wslulciuc wslulciuc added the hacktoberfest Let's celebrate open source together! label Oct 3, 2024
@wslulciuc
Copy link
Member

@NisargChokshi45, done! I've also added @phixMe as the reviewer.

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please fill in the Description and Solution for your next PR. I one sentence description would be fine for something like this.

@phixMe phixMe merged commit 1d90f18 into MarquezProject:main Oct 3, 2024
16 checks passed
Copy link

boring-cyborg bot commented Oct 3, 2024

Great job! Congrats on your first merged pull request in the Marquez project!

@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Let's celebrate open source together! web
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants