Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET /api/v1/jobs #2930

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add GET /api/v1/jobs #2930

merged 1 commit into from
Oct 17, 2024

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Oct 17, 2024

This PR adds the endpoint GET /api/v1/jobs, no longer requiring a namespace. You can still list jobs for a given namesake via GET /api/v1/namespaces/{namespace}/jobs

Signed-off-by: Willy Lulciuc <willy.lulciuc@gmail.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 0042457
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/671181a4c0aed80008071df5

@wslulciuc wslulciuc requested a review from phixMe October 17, 2024 21:31
@wslulciuc wslulciuc added this to the 0.50.0 milestone Oct 17, 2024
@wslulciuc wslulciuc enabled auto-merge (squash) October 17, 2024 21:32
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (90a2f65) to head (0042457).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/src/main/java/marquez/api/JobResource.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2930      +/-   ##
============================================
+ Coverage     81.02%   81.13%   +0.10%     
- Complexity      241     1507    +1266     
============================================
  Files            43      268     +225     
  Lines           996     7367    +6371     
  Branches         40      330     +290     
============================================
+ Hits            807     5977    +5170     
- Misses          160     1229    +1069     
- Partials         29      161     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc merged commit 8fb6338 into main Oct 17, 2024
16 checks passed
@wslulciuc wslulciuc deleted the feature/list-jobs-across-namespaces branch October 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants