Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Facets #2979

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Job Facets #2979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e3593
Adding job facets.
phixMe Nov 12, 2024
485e1e2
Merge branch 'main' into feature/job-facets
phixMe Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions web/src/components/jobs/RunInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ type RunInfoProps = {

const RunInfo: FunctionComponent<RunInfoProps> = (props) => {
const { run, jobFacets, fetchJobFacets, resetFacets } = props
const i18next = require('i18next')

useEffect(() => {
fetchJobFacets(run.id)
Expand All @@ -65,16 +64,20 @@ const RunInfo: FunctionComponent<RunInfoProps> = (props) => {
language={(jobFacets.sourceCode as SourceCodeFacet)?.language}
/>
)}
{jobFacets && (
<Box mt={2}>
<Box mb={1}>
<MqText subheading>JOB FACETS</MqText>
</Box>
<MqJsonView data={jobFacets} aria-label={'Job facets'} aria-required='true' />
</Box>
)}
{run.facets && (
<Box mt={2}>
<Box mb={1}>
<MqText subheading>{i18next.t('jobs.runinfo_subhead')}</MqText>
<MqText subheading>RUN FACETS</MqText>
</Box>
<MqJsonView
data={run.facets}
aria-label={i18next.t('jobs.facets_subhead_aria')}
aria-required='true'
/>
<MqJsonView data={run.facets} aria-label={'Run facets'} aria-required='true' />
</Box>
)}
</Box>
Expand Down
Loading