add opt-in strict string format

[zzstoatzz]

adds pydantic validation per #406 (comment). see the usage example

does not address open questions regarding the language types or re2. happy to chat on those if they'd be blocking here

may close #406

notes

I ran this to generate models

uvx poetry run atproto gen models

and this to update docs

uvx poetry run make -s -C docs gen

and this to run the new tests

uvx poetry run pytest tests/test_atproto_client/models/tests/test_string_formats.py

if desirable, I can follow up this PR to add contribution instructions to the current README section (for uv at least, and perhaps a TODO for proper poetry usage, since I don't really use that) - let me know!

[zzstoatzz]

let me know:

• if you know a good place to go grab some representative data for these

• if I should add tests elsewhere covering generated interfaces

[MarshalX]

no need for generated interfaces. but it will be good to have smth like this:

class TestModel(ModelBase):
    did_field: str_frmt.DidField...


def test_did_field_validation:
    test_data = {did_field: blaablabla}
    with pytestExpectException(ValueError) as exc_info:
        get_or_create(test_data, TestModel, string_strings=True)

	assert 'did invalid` in str(exc_info)

[MarshalX]

speaking of test data i will try to find it later somewhere in official bsky repo

[MarshalX]

@zzstoatzz hi pls use this files for tests https://github.com/bluesky-social/atproto/tree/main/interop-test-files/syntax. Just download it from the official repo and put to this one. pls do not rename of modify these files. because we want to keep it with easy sync with the official repo without additional effort

[zzstoatzz]

here's the critical "pydantic usage" making use of validation context

[MarshalX]

could we try to invert this if statement? to avoid using of "not"

smth like:

Suggested change

	def only_validate_if_strict(validate_fn: core_schema.WithInfoValidatorFunction) -> Callable:
	"""Skip validation if not opting into strict validation."""
	def wrapper(v: str, info: ValidationInfo) -> str:
	if not (info and isinstance(info.context, Mapping) and info.context.get(_OPT_IN_KEY, False)):
	return v
	return validate_fn(v, info)
	return wrapper
	def only_validate_if_strict(validate_fn: core_schema.WithInfoValidatorFunction) -> Callable:
	"""Skip validation if not opting into strict validation."""
	def wrapper(v: str, info: ValidationInfo) -> str:
	if info and isinstance(info.context, Mapping) and info.context.get(_OPT_IN_KEY, False):
	return validate_fn(v, info)
	return v
	return wrapper

[MarshalX]

awesome hard work! thank you! speaking of your gotten knowledges about how to contribute we need to write CONTRIBUTING.md someday. but this will be separated PR for sure

[MarshalX]

no need for generated interfaces. but it will be good to have smth like this:

class TestModel(ModelBase):
    did_field: str_frmt.DidField...


def test_did_field_validation:
    test_data = {did_field: blaablabla}
    with pytestExpectException(ValueError) as exc_info:
        get_or_create(test_data, TestModel, string_strings=True)

	assert 'did invalid` in str(exc_info)

[MarshalX]

speaking of test data i will try to find it later somewhere in official bsky repo

[zzstoatzz]

thanks for the review @MarshalX! comments should be addressed in 6ad722a