Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to send aspect ratio with send_image and send_images #480

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Add ability to send aspect ratio with send_image and send_images #480

merged 7 commits into from
Dec 3, 2024

Conversation

palmer-cl
Copy link
Contributor

@palmer-cl palmer-cl commented Dec 2, 2024 •
edited
Loading

  • Adds ability to send aspect_ratio with send_images and send_image
  • Updated docs to add example using the models

closes #475

@palmer-cl palmer-cl changed the title fix: add ability to send aspect ratio with send_image and send_images Add ability to send aspect ratio with send_image and send_images Dec 2, 2024
MarshalX
MarshalX reviewed Dec 2, 2024
View reviewed changes
Copy link
Owner

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! let's do not touch README.md at all. example in examples/send_image.py is enough

packages/atproto_client/client/client.py Outdated Show resolved Hide resolved
examples/send_image.py Show resolved Hide resolved
examples/send_image.py Outdated Show resolved Hide resolved
@palmer-cl
Copy link
Contributor Author

@MarshalX updated! Let me know if there's anything else needed.

@MarshalX
Copy link
Owner

MarshalX commented Dec 2, 2024

@palmer-cl pls use ruff as formatter. there is bunch of unexpected formatting changes

@palmer-cl
Copy link
Contributor Author

palmer-cl commented Dec 2, 2024 •
edited
Loading

@palmer-cl pls use ruff as formatter. there is bunch of unexpected formatting changes

@MarshalX see output after running ruff format

image

all files are unchanged.

@MarshalX
Copy link
Owner

MarshalX commented Dec 2, 2024

poetry run ruff check .?

@MarshalX
Copy link
Owner

MarshalX commented Dec 2, 2024 •
edited
Loading

ah, sorry. not the linter staff. diference in sync and async client

image

@palmer-cl
Copy link
Contributor Author

Ok I saw the missing comment. Added that in. Looks like that diff was reporting something towards the top of the file but it looks like a formatting diff? Ln 20-23 in your screenshot above?

@palmer-cl
Copy link
Contributor Author

@MarshalX are we able to merge this? I know a few people waiting on this functionality. Thanks!

@MarshalX
Copy link
Owner

MarshalX commented Dec 3, 2024

sure. gonna release soon

@MarshalX MarshalX merged commit 3f61605 into MarshalX:main Dec 3, 2024
23 checks passed
@WriterStat WriterStat mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshalX MarshalX MarshalX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

send_image and send_images should support aspect ratio parameter
2 participants
@palmer-cl @MarshalX