-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a clear, obvious way to remove hotkeys to improve UX #2883
Add a clear, obvious way to remove hotkeys to improve UX #2883
Conversation
💖 Thanks for opening this pull request! 💖 |
c23b001
to
e831ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide a screenshot showing what this looks like 👍
position: 'relative', | ||
}, | ||
clearButton: { | ||
'background-color': 'Transparent', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just be backgroundColor
and the value should be all lower case 👍
e831ec1
to
bb84ed5
Compare
Looks reasonable. Does it also work with the dark theme? |
No, the icon doesn't change color. Thanks for pointing that out, I'll take a look at it. |
I have changed the |
|
bb84ed5
to
a80944a
Compare
@MarshallOfSound this is good to go, just pulled and reviewed. |
Congrats on merging your first pull request! Have a ⭐ |
The solution is based on bradrisse's comment here:
mui/material-ui#2932
Based on that thread, it seems to me that there is currently no better way to add the requested button.