feat: add support for new session extension handling in Electron 9

[ghost]

Electron 9 deprecates the use of BrowserWindow extension handling so I implemented the new way for handling extensions.

See here:

• BrowserWindow.getDevToolsExtensions()
• BrowserWindow.addDevToolsExtension(path)
• BrowserWindow.removeDevToolsExtension(name)

[inlet]

The latest version of react devtools (v7.4.0) is not compatible with Electron 9.

I get this warning:

ExtensionLoadWarning: Warnings loading extension at 
/Users/pbrouwer/Library/Application Support/Google/Chrome
/Default/Extensions/fmkadmapgofadopljbjfkapdkoienihi/4.7.0_0: 
Unrecognized manifest key 'browser_action'. 
Unrecognized manifest key 'minimum_chrome_version'. 
Unrecognized manifest key 'update_url'. 
Manifest contains a differential_fingerprint key that will be overridden on extension update. 
Cannot load extension with file or directory name _metadata. 
Filenames starting with "_" are reserved for use by the system.

[kylewetton]

@inlet to confirm, is that a Redux DevTools issue or an issue with electron-devtools-installers way of installing it?

[inlet]

@kylewetton it seems that electron 9 has changed loading of extensions. The issue is not this lib (sorry for commenting on this issue), it simply doesn't work if you do session.defaultSession.loadExtension with the React Devtools extension.

[byte47]

any update on this?

[reZach]

@inlet Have you made an issue in the react devtools extension repo? I'm also interested in seeing this fixed.

[inlet]

I’m not sure if this issue is React Devtools, Electron or even Chromium related,
See electron/electron#23662

[jakubzitny]

I also tried this PR, cloned repo and linked to my codebase. And React devtools do not work. The message I can see (probably related, not sure how much) is:

ExtensionLoadWarning: Warnings loading extension at /Users/user/Library/Application Support/Avocode/extensions/fmkadmapgofadopljbjfkapdkoienihi: Unrecognized manifest key 'browser_action'. Unrecognized manifest key 'minimum_chrome_version'. Unrecognized manifest key 'update_url'. Cannot load extension with file or directory name _metadata. Filenames starting with "_" are reserved for use by the system.

I am also loading the browser window via browserWindow.loadUrl("file://..."), same way as @develerik mentioned in #130 (comment).

Side note: We have immutable devtools (these need to be loaded in renderer) and that works. React devtools (need to be loaded from main process) do not work though.

If anyone can push mi in the right direction, I can help with this so we can merge and release this.

EIDT: I read more of the linked issues and realized it's probably not a bug in electron-devtools-installer

• React DevTools and Redux DevTools tabs sometimes not appearing Electron@9.0.0 electron/electron#23662
• Bug: DevTools tabs don't show up sometimes in latest release facebook/react#19002

[sdc224]

is it going to be available in the latest versions of electron-devtools-installer?

[MarshallOfSound]

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀