Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extension): unrecognized manifest key #177

Closed
wants to merge 3 commits into from
Closed

fix(extension): unrecognized manifest key #177

wants to merge 3 commits into from

Conversation

BlackHole1
Copy link
Contributor

No description provided.

@BlackHole1 BlackHole1 mentioned this pull request Mar 18, 2021
Open
brunos3d
brunos3d approved these changes Apr 2, 2021
View reviewed changes
Copy link

@brunos3d brunos3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@BlackHole1
Copy link
Contributor Author

@MarshallOfSound When can this PR be merged?

@BlackHole1
Copy link
Contributor Author

@MarshallOfSound Is there something wrong with this PR that needs to be changed? If yes, please let me know and I will fix it.

This was referenced Jun 9, 2021
Open
Merged
@dewinterjack
Copy link

It would be good to get this merged

@BlackHole1
Copy link
Contributor Author

BlackHole1 commented Jun 17, 2021 •
edited
Loading

It would be good to get this merged

In fact, this is actually a bug in chromium and electron, and this PR is only useful to block them downstream. The best thing to do is to submit separate PR for chromium and electron, in fact I'm already doing it, here are the PR I submitted to them you can follow the latest progress through these.

https://chromium-review.googlesource.com/c/chromium/src/+/2959994

electron/electron#29695

@goosewobbler goosewobbler mentioned this pull request Jul 2, 2021
Closed
@agentschmitt
Copy link

would be really nice to have the annoying warnings gone :)

@BlackHole1
Copy link
Contributor Author

BlackHole1 commented Sep 3, 2021 •
edited
Loading

I will close this PR as the fix PR I submitted to electron has been merged. (electron/electron#29695)

It is not certain which version of electron will carry it.

@BlackHole1 BlackHole1 closed this Sep 3, 2021
@BlackHole1 BlackHole1 mentioned this pull request Sep 6, 2021
Closed
@BlackHole1 BlackHole1 deleted the fix-electron-warning branch September 6, 2021 02:02
@BlackHole1 BlackHole1 mentioned this pull request Sep 6, 2021
Closed
@BlackHole1
Copy link
Contributor Author

PR will be present in 16.x.

@BlackHole1

This comment has been minimized.

Sign in to view
@MarshallOfSound
Copy link
Owner

Advertising other modules to capitalize off of SEO of an existing module is bad form. Please do not do so, I'd normally let it slide but doing it across multiple issues shows clear intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@brunos3d brunos3d brunos3d approved these changes

@jeffdanielperso jeffdanielperso jeffdanielperso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BlackHole1 @dewinterjack @agentschmitt @MarshallOfSound @prince-chrismc @brunos3d @jeffdanielperso