Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: New status to indicate that all remotes are disconnected #306

Open
1 of 7 tasks
abryant opened this issue Dec 23, 2024 · 2 comments
Open
1 of 7 tasks

Comments

@abryant
Copy link

abryant commented Dec 23, 2024

Relevant components

  • Standalone tray application (based on Qt Widgets)
  • Plasmoid/applet for Plasma desktop
  • Dolphin integration
  • Command line tool (syncthingctl)
  • Integrated Syncthing instance (libsyncthing)
  • Android app or mobile UI in general
  • Backend libraries

Is your feature request specific to a certain platform/environment? Please specify.
It doesn't seem to be, but I've only tried the Plasmoid.

Is your feature request related to a problem? Please describe.
I've just started using Syncthing, and it seems weird that the tray icon can't show me whether remote devices are disconnected, even when I can see they they're disconnected by opening up the panel.

I've been reading a bit of the code, and initially thought that the "Disconnected" status was meant to mean this, but on closer inspection it seems to just mean that the plasmoid is disconnected from Syncthing. The relevant code seems to be around here:

if (dev.status == SyncthingDevStatus::Synchronizing) {

Describe the solution you'd like
Add an option to make the main icon for the plasmoid change when all remotes are disconnected. This would be an extra checkbox under "Connection -> Overall status" like "All remotes are disconnected".

Describe alternatives you've considered
Clicking on the icon manually whenever I want to be sure that everything has been synced to my server.

Additional context
SyncthingTray-StatusIcon

@Martchus
Copy link
Owner

This is something I have already on my mind for a long time but I've never come to implement it. Maybe it is time :-)

This should actually not be that difficult to implement considering the status computation is already configurable. Maybe it makes sense to come up with a distinct "badge icon" for this, though.

I've been reading a bit of the code, and initially thought that the "Disconnected" status was meant to mean this, but on closer inspection it seems to just mean that the plasmoid is disconnected from Syncthing. The relevant code seems to be around here:

Yes, that's how it is.

Martchus added a commit that referenced this issue Dec 24, 2024
* Add option to show a distinct status icon if no remote device is
  connected, see #306
* Introduce new connection status and status computation flags to implement
  this new option
* Replace unused SVG path with a new SVG path for an "X" emblem
@Martchus
Copy link
Owner

I pushed a commit implementing this on the master branch. If configured it now shows an "X" emblem in case there's no remote device connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants