Skip to content

Commit

Permalink
experiment(#109): only keep the reasoning, not the quote, when genera…
Browse files Browse the repository at this point in the history
…ting questions (#117)

Fixes #109
  • Loading branch information
MartinBernstorff authored Mar 31, 2024
1 parent 4cec86c commit 9fc42d8
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions memorymarker/question_generator/steps/qa_generation.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ class QuestionGenerationStep(FlowStep):
Document: "{document_title}"
Highlight: {highlighted_text}
{reasoning}
Please generate between {lower_bound} and {upper_bound} question/answer pairs to reinforce understanding of the concept.
Expand All @@ -38,7 +36,6 @@ def identity(self) -> str:
async def __call__(self, highlight: "ReasonedHighlight") -> "ReasonedHighlight":
prompt = self.prompt.format(
document_title=highlight.source_document.title,
highlighted_text=highlight.highlighted_text,
reasoning=f"""{highlight.reasoning}""" if highlight.reasoning else "",
lower_bound=self.n_questions[0],
upper_bound=self.n_questions[1],
Expand Down

0 comments on commit 9fc42d8

Please sign in to comment.