fix: fix thread blocking issue (#1119)

MartinWitt · Oct 1, 2023 · 20e8577 · 20e8577
1 parent a99d872
commit 20e8577
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 15 deletions.
diff --git a/...tion/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonAnalyzerResult.java b/...tion/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonAnalyzerResult.java
@@ -62,7 +62,8 @@ private static Optional<String> tryGetOriginalSourceCode(SourcePositionHolder el
     }
   }
 
-  private static Optional<String> getRelativeFilePath(SourcePositionHolder positionHolder, String rootPath) {
+  private static Optional<String> getRelativeFilePath(
+      SourcePositionHolder positionHolder, String rootPath) {
     try {
       File file = positionHolder.getPosition().getFile();
       Path filePath = Paths.get(file.getAbsolutePath());

diff --git a/...sformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonRefactor.java b/...sformation/src/main/java/xyz/keksdose/spoon/code_solver/analyzer/spoon/SpoonRefactor.java
@@ -18,7 +18,8 @@ public class SpoonRefactor extends TransformationProcessor<CtType<?>> {
   private Map<RuleId, Function<AnalyzerResult, AbstractRefactoring>> ruleParser;
   private List<AbstractRefactoring> refactors;
 
-  public SpoonRefactor(ChangeListener changeListener, Iterable<? extends AnalyzerResult> badSmells) {
+  public SpoonRefactor(
+      ChangeListener changeListener, Iterable<? extends AnalyzerResult> badSmells) {
     super(changeListener);
     ruleParser = new HashMap<>();
     refactors = new ArrayList<>();

diff --git a/github-bot/build.gradle b/github-bot/build.gradle
@@ -24,7 +24,6 @@ dependencies {
 	implementation("io.quarkus:quarkus-keycloak-authorization")
 	implementation("io.quarkus:quarkus-micrometer-registry-prometheus")
 	testImplementation group: 'org.assertj', name: 'assertj-core', version: '3.24.2'
-	implementation("io.quarkus:quarkus-opentelemetry")
 	implementation project(":application")
 	implementation project(":commons")
 	implementation "io.quarkiverse.loggingmanager:quarkus-logging-manager:3.0.2"

diff --git a/.../main/java/io/github/martinwitt/laughing_train/api/graphql/endpoints/BadSmellGraphQL.java b/.../main/java/io/github/martinwitt/laughing_train/api/graphql/endpoints/BadSmellGraphQL.java
@@ -7,8 +7,6 @@
 import io.github.martinwitt.laughing_train.persistence.repository.ProjectRepository;
 import io.github.martinwitt.laughing_train.summary.GetFixableBadSmells;
 import io.github.martinwitt.spoon_analyzer.badsmells.SpoonRules;
-import io.smallrye.common.annotation.RunOnVirtualThread;
-import jakarta.enterprise.context.RequestScoped;
 import jakarta.inject.Inject;
 import java.util.Arrays;
 import java.util.List;
@@ -18,8 +16,6 @@
 import org.eclipse.microprofile.graphql.Query;
 
 @GraphQLApi
-@RequestScoped
-@RunOnVirtualThread
 public class BadSmellGraphQL {
 
   @Inject BadSmellRepository badSmellRepository;

diff --git a/...c/main/java/io/github/martinwitt/laughing_train/api/graphql/endpoints/ProjectGraphQL.java b/...c/main/java/io/github/martinwitt/laughing_train/api/graphql/endpoints/ProjectGraphQL.java
@@ -12,8 +12,6 @@
 import io.github.martinwitt.laughing_train.persistence.repository.ProjectRepository;
 import io.github.martinwitt.laughing_train.services.ProjectConfigService;
 import io.quarkus.security.Authenticated;
-import io.smallrye.common.annotation.RunOnVirtualThread;
-import jakarta.enterprise.context.RequestScoped;
 import jakarta.inject.Inject;
 import java.util.List;
 import org.eclipse.microprofile.graphql.DefaultValue;
@@ -23,8 +21,6 @@
 import org.eclipse.microprofile.graphql.Query;
 
 @GraphQLApi
-@RequestScoped
-@RunOnVirtualThread
 public class ProjectGraphQL {
 
   private static final FluentLogger logger = FluentLogger.forEnclosingClass();

diff --git a/.../main/java/io/github/martinwitt/laughing_train/api/graphql/endpoints/RefactorGraphQL.java b/.../main/java/io/github/martinwitt/laughing_train/api/graphql/endpoints/RefactorGraphQL.java
@@ -6,8 +6,6 @@
 import io.github.martinwitt.laughing_train.persistence.repository.BadSmellRepository;
 import io.github.martinwitt.laughing_train.services.RefactorService;
 import io.quarkus.security.Authenticated;
-import io.smallrye.common.annotation.RunOnVirtualThread;
-import jakarta.enterprise.context.RequestScoped;
 import jakarta.inject.Inject;
 import java.util.Arrays;
 import java.util.Collection;
@@ -22,8 +20,6 @@
 import xyz.keksdose.spoon.code_solver.analyzer.qodana.QodanaRules;
 
 @GraphQLApi
-@RequestScoped
-@RunOnVirtualThread
 public class RefactorGraphQL {
   private static final FluentLogger logger = FluentLogger.forEnclosingClass();