fix(spoon): Disable InnerClassMayBeStatic rule (#896)

MartinWitt · Jul 25, 2023 · 5484232 · 5484232
1 parent cd8bbb4
commit 5484232
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/...-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/DataBaseMigration.java b/...-bot/src/main/java/io/github/martinwitt/laughing_train/persistence/DataBaseMigration.java
@@ -76,6 +76,7 @@ private void migrateDataBase(Promise<Object> promise) {
         removeDuplicatedProjects();
         removeRuleIdsWithSpaces();
         removeBadSmellsWithWrongFolder();
+        deleteBadSmellWithManyFalsePositives();
         logger.atInfo().log("Finished migrating database");
         promise.complete();
     }
@@ -146,4 +147,12 @@ private void removeBadSmellsWithWrongFolder() {
                 .deleteMany(Filters.and(Filters.regex("filePath", ".*/tmp/.*"), Filters.eq("analyzer", "Spoon")));
         logger.atInfo().log("Removed %d bad smells with ruleId containing spaces", deleteMany.getDeletedCount());
     }
+
+    private void deleteBadSmellWithManyFalsePositives() {
+        DeleteResult deleteMany = badSmellRepositoryImpl
+                .mongoCollection()
+                .deleteMany(
+                        Filters.and(Filters.eq("ruleID", "InnerClassMayBeStatic"), Filters.eq("analyzer", "Spoon")));
+        logger.atInfo().log("Removed %d bad smells for rule InnerClassMayBeStatic", deleteMany.getDeletedCount());
+    }
 }
diff --git a/spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/SpoonAnalyzer.java b/spoon-analyzer/src/main/java/io/github/martinwitt/spoon_analyzer/SpoonAnalyzer.java
@@ -6,7 +6,6 @@
 import io.github.martinwitt.spoon_analyzer.badsmells.array_can_be_replaced_with_enum_values.ArrayCanBeReplacedWithEnumValuesAnalyzer;
 import io.github.martinwitt.spoon_analyzer.badsmells.charset_object_can_be_used.CharsetObjectCanBeUsedAnalyzer;
 import io.github.martinwitt.spoon_analyzer.badsmells.final_static_method.FinalStaticMethodAnalyzer;
-import io.github.martinwitt.spoon_analyzer.badsmells.innerclass_may_be_static.InnerClassMayBeStaticAnalyzer;
 import io.github.martinwitt.spoon_analyzer.badsmells.non_protected_constructor_In_abstract_class.NonProtectedConstructorInAbstractClassAnalyzer;
 import io.github.martinwitt.spoon_analyzer.badsmells.private_final_method.PrivateFinalMethodAnalyzer;
 import io.github.martinwitt.spoon_analyzer.badsmells.size_replaceable_by_is_empty.SizeReplaceableByIsEmptyAnalyzer;
@@ -31,7 +30,8 @@ public SpoonAnalyzer() {
         localAnalyzers.add(new CharsetObjectCanBeUsedAnalyzer());
         localAnalyzers.add(new FinalStaticMethodAnalyzer());
         localAnalyzers.add(new IndexOfReplaceableByContainsAnalyzer());
-        localAnalyzers.add(new InnerClassMayBeStaticAnalyzer());
+        // currently produces too many false positives
+        // localAnalyzers.add(new InnerClassMayBeStaticAnalyzer());
         localAnalyzers.add(new NonProtectedConstructorInAbstractClassAnalyzer());
         localAnalyzers.add(new PrivateFinalMethodAnalyzer());
         localAnalyzers.add(new SizeReplaceableByIsEmptyAnalyzer());