Fixed the exefs filesystem parser such that it doesnt attempt to deco… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase was attempting to lzss decompress the banner and icon elements of the exeFS when loading the Alpha Sapphire cxi, which according to the exeFS documentation here, do not get LZSS compressed: https://www.3dbrew.org/wiki/ExeFS
As such, it was reading junk data.
This PR adds a quick check to the CXIFileSystem methods to ensure that exeFS files that are not compressed do not have the lzss decompression algorithm run on them.