Fixed bug where follower sprites did not update correctly after exiting the terrain tag editor #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the terrain tag editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug mentioned in the title. The issue is that if the player has a follower with them, then enters and exits the terrain tag editor from the Debug menu (even without making any edits), the follower sprite would start to move weirdly until the next map transfer (attached a gif below to demonstrate the issue).
The root cause of this issue is that after exiting the terrain tag editor, the game reloads all of the spritesets, including the current map. The follower sprites have an internal attribute
@mapthat points to the current map object, but when the spritesets get reloaded, the current map object changes, so the follower sprites are still pointing to the old map object. This messes up the calculations used for the follower sprites' display coordinates as it relies on the old map's display coordinates instead of the new one.This PR fixes this issue by simply refreshing the follower factory in between disposing the old spritesets and creating the new ones after exiting the terrain tag editor.