Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating pcieinfo support #6

Open
wants to merge 1 commit into
base: target
Choose a base branch
from
Open

updating pcieinfo support #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions show/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1848,9 +1848,9 @@ def ssdhealth(device, verbose, vendor):
@click.option('-c', '--check', is_flag=True, help="Check the platfome pcie device")
def pcieinfo(check, verbose):
"""Show Device PCIe Info"""
cmd = "pcieutil pcie_show"
cmd = "pcieutil pcie-show"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show platform pcieinfo
Usage: pcieutil [OPTIONS] COMMAND [ARGS]...
Try "pcieutil --help" for help.

Error: No such command "pcie_show".
admin@sonic:~$

pcieutil support pcie-show

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin@sonic:~$ pcieutil --help
Usage: pcieutil [OPTIONS] COMMAND [ARGS]...

pcieutil - Command line utility for checking pci device

Options:
--help Show this message and exit.

Commands:
pcie-check Check PCIe Device
pcie-generate Generate config file with current pci device
pcie-show Display PCIe Device
version Display version info
admin@sonic:~$

if check:
cmd = "pcieutil pcie_check"
cmd = "pcieutil pcie-check"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why '-'?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check how it is wrking in Intel sonic?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antony-rheneus

checked in intel board10.28.32.69:
show platform pcieinfo
Usage: pcieutil [OPTIONS] COMMAND [ARGS]...
Try "pcieutil --help" for help.

Error: No such command "pcie_show".
admin@Sonic-L1:~$

run_command(cmd, display_cmd=verbose)

# 'fan' subcommand ("show platform fan")
Expand Down