Custom ACL Based Metering - ACL_Loader #9
+72
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaygol
force-pushed
the
pbm
branch
3 times, most recently
from
acdc314 to
06b2b4c
Compare
shaygol
requested review from
amazor,
matiAlfaro,
VladimirKuk,
shiraez,
aviramd and
DanielaMurin
acl_loader/main.py
Outdated
| @click.option('--session_name', type=click.STRING, required=False) | ||
| @click.option('--mirror_stage', type=click.Choice(["ingress", "egress"]), default="ingress") | ||
| @click.option('--max_priority', type=click.INT, required=False) | ||
| @click.option('--skip_action_validation', is_flag=True, default=False, help="Skip action validation") | ||
| @click.pass_context | ||
| def full(ctx, filename, table_name, session_name, mirror_stage, max_priority, skip_action_validation): | ||
| def full(ctx, filename, table_name, session_name, mirror_stage, max_priority, policer_name, skip_action_validation): |
There was a problem hiding this comment.
Is there a reason why the policer_name was not added to the end of the definition?
There was a problem hiding this comment.
To be consistent with the parameters' purpose or meaning - policer_name is more related to the rule behavior.
shaygol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.