-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assert): added AssertDirEmpty and AssertDirNotEmpty. fixes #37 #52
feat(assert): added AssertDirEmpty and AssertDirNotEmpty. fixes #37 #52
Conversation
Codecov Report
@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 87.90% 88.10% +0.20%
==========================================
Files 10 10
Lines 587 597 +10
==========================================
+ Hits 516 526 +10
Misses 37 37
Partials 34 34
Continue to review full report at Codecov.
|
Hi @schambers, the PR looks good! Could please fix the linting error (you can see it in the changed files view), thanks! |
@MarvinJWendt should be all set now! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of small changes that I'd like.
I will merge the PR as soon as they are fixed :)
Thanks for the submission!
Co-authored-by: Marvin Wendt <git@marvinjwendt.com>
Co-authored-by: Marvin Wendt <git@marvinjwendt.com>
Should be all set to go now @MarvinJWendt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great work!
Could you please resolve the merge conflict?
@MarvinJWendt should be all set now. Conflicts resolved and fixed up the formatting. Thanks! |
Adds AssertDirEmpty, AssertDirNotEmpty by checking for io.EOF to assert an empty directory or not. This is more efficient than retrieving a slice of the objects in the directory.
I think everything here works, please let me know if I missed anything obvious or this is missing something.
Thank you!