Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill disregards strokestyle #38

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SignaturePad/SignaturePad.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<TargetFramework>net8.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<Version>8.1.2</Version>
<Version>8.1.3</Version>
<Description>A simple to use blazor component to draw a signature.</Description>
<Copyright>2023</Copyright>
<RepositoryUrl>https://github.com/MarvinKlein1508/SignaturePad</RepositoryUrl>
Expand Down
2 changes: 1 addition & 1 deletion SignaturePad/SignaturePad.razor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ protected async override Task OnAfterRenderAsync(bool firstRender)
{
if (firstRender)
{
_jsModule = await jsRuntime.InvokeAsync<IJSObjectReference>("import", "./_content/Blazor.SignaturePad/sigpad.interop.js?ver=8.1.2");
_jsModule = await jsRuntime.InvokeAsync<IJSObjectReference>("import", "./_content/Blazor.SignaturePad/sigpad.interop.js?ver=8.1.3");
await Setup();
await Update();
await UpdateImage();
Expand Down
2 changes: 1 addition & 1 deletion SignaturePad/wwwroot/sigpad.interop.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Sigpad from "./sigpad.min.js?ver=8.1.2"
import Sigpad from "./sigpad.min.js?ver=8.1.3"
var dotNetHelper;

export function setup(id, reference, options, image) {
Expand Down
18 changes: 11 additions & 7 deletions SignaturePad/wwwroot/sigpad.min.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

const sigpadMap = new Map();

function drawPoints(ctx, points) {
// finished param: only draw last point after points wont differ from exec to exec
function drawPoints(ctx, points, finished) {
// draw a point instead
if (points.length == 1) {
var b = points[0];
Expand All @@ -17,7 +18,7 @@ function drawPoints(ctx, points) {
}

// draw line for just two points
if (points.length == 2) {
if (points.length == 2 && finished) {
ctx.beginPath(), ctx.moveTo(points[0].x, points[0].y);
ctx.lineTo(points[1].x, points[1].y);
ctx.stroke();
Expand All @@ -32,7 +33,7 @@ function drawPoints(ctx, points) {
d = (points[i].y + points[i + 1].y) / 2;
ctx.quadraticCurveTo(points[i].x, points[i].y, c, d);
}
if (i < points.length - 1)
if (i < points.length - 1 && finished)
ctx.quadraticCurveTo(points[i].x, points[i].y, points[i + 1].x, points[i + 1].y);
//ctx.closePath();
ctx.stroke();
Expand Down Expand Up @@ -98,6 +99,7 @@ export default class Sigpad {
ctx = this._element.getContext("2d");
}
ctx.strokeStyle = this._config.strokeStyle;
ctx.fillStyle = this._config.strokeStyle;
ctx.lineWidth = this._config.lineWidth;
ctx.lineCap = this._config.lineCap;
ctx.lineJoin = this._config.lineJoin;
Expand Down Expand Up @@ -230,7 +232,7 @@ export default class Sigpad {
return;
}

data.render();
data.render(true);
data._drawing = false;

const event = new CustomEvent('sigpad.finish', { detail: data.getImage() });
Expand Down Expand Up @@ -265,14 +267,16 @@ export default class Sigpad {
}
}

render() {
//finished: signal to renderer that all individual mouse position arrays are complete
render(finished) {
if (this._element.width != this._element.clientWidth) {
this._element.width = this._element.clientWidth;
}

if (this._drawing) {
var ctx = this._element.getContext("2d");
this._applyOptions(ctx);
this._mousePosis.filter((stroke) => stroke.length > 0).forEach((stroke) => drawPoints(ctx, stroke));
this._mousePosis.filter((stroke) => stroke.length > 0).forEach((stroke) => drawPoints(ctx, stroke, finished));
}
}
}
Expand All @@ -291,7 +295,7 @@ const requestAnimFrame = (function (callback) {
(function renderSignatures() {
requestAnimFrame(renderSignatures);
Sigpad.getAllInstances().forEach((sigpad, index) => {
sigpad.render();
sigpad.render(false);
});

})();
Loading