Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Build Configuration to be a variable in the vsts task #2

Open
ravensorb opened this issue Oct 24, 2018 · 2 comments
Open

Enable Build Configuration to be a variable in the vsts task #2

ravensorb opened this issue Oct 24, 2018 · 2 comments

Comments

@ravensorb
Copy link

It looks like the build configuration is hard coded as "debug" -- any thoughts to make it a build parameter?
@Masahigo
Copy link
Owner

Hi,

Are you referring to the default settings defined in Gulp config(?)
https://github.com/Masahigo/sitecore-azure-devops/blob/master/helix%20solution/gulp-config.js

That config is overridden in Gulp ci (row 26)
https://github.com/Masahigo/sitecore-azure-devops/blob/master/helix%20solution/gulpfile-ci.js

So basically if you want to override it you could modify the gulp task's params to support this.

Cheers,
Masi

Masahigo added a commit that referenced this issue Oct 25, 2018
@Masahigo
#2: Fix correct AS api version
cf001c5 
Use correct AS api version
- https://github.com/Sitecorere-Azure-Quickstart-Templates/blob/master/Sitecore%208.2.5/xm/nested/appl.json
- See also https://kb.sitecore.net/articles/549969
@ravensorb
Copy link
Author

ravensorb commented Oct 25, 2018 •
edited
Loading

Not exactly -- I am referring to this line

sitecore-azure-devops/sitecore-vsts-tasks/multiple-projs-webdploy/package-multiproj-solution-for-webdeploy.ps1

Line 48 in cf001c5

<LastUsedBuildConfiguration>Debug</LastUsedBuildConfiguration>

Its the one that controls what Configuration is used for the web package. Ideally it would be great to be able to set the configuration and have a way to indicate if the parameters.xml file was supposed to be used during the web package.

@ravensorb ravensorb changed the title Enable Build Configuration to be a variable Enable Build Configuration to be a variable in the vsts task Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ravensorb @Masahigo