Update to latest upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Bligh <alex@alex.org.uk>
namecheap MX records are handled a bit specially compared to other records; it seems all records has the MXPref field, but only the MX record uses it. maybe a new feature or something. It used to not be able to create MX records, but now it can.
…sent (#506) * Fixed create and update operations for GoDaddy if CAA records are present The GoDaddy API breaks (returning 422) if you try to submit a CAA record. So when you create a new record, if the domain has one or more CAA records, the create will fail (update fails the same way). This change simply submits the new (or updated) record instead of submitting all records. The logic for locating the record to update remains the same as before, but now, it won't try to send the update if nothing actually changed, nor will a message be logged about updating if it didn't attempt to update. This doesn't address the problems with delete, as the GoDaddy API still doesn't let you delete a single record. So for domains with CAA records, any delete action will continue to fail. * Fixed GoDaddy provider to handle things as tests expect Fixed _create_record to ignore duplicates and handle record sets appropriately. Removed some debugging code that was left in create_record by mistake. Fixed _update_record to handle the potential case of chaning the name of a record, when update_record updates via identifier, which happens in the tests. Fixed _delete_record to work in more cases when CAA records exist, by updating only the records of a given type. If the record is identified by its identifier. Comment at the top has been updated to reflect the changes. * Updated tests for GoDaddy provider to match new functionality. * Fixed typo in variable name Also fixed some pylint warnings
delete circleci integration. no longer necessary.
…tzner does not need the fqdn as record name. This leads to major errors like: record name=sub1.my-fqdn.tld --> record created with final name sub1.my-fqdn.tld.my-fqdn.tld
Previously, a rrset ttl could be set only when creating a new record, whereas with this change, now a new ttl value can be specified.
* add skeleton and request helper method * add authenticate * add list record function * compacter var naming * fix wrong var naming * add create_record for dynu.com * add delete_record for dynu.com * add _update_record for Dynu.com * fix delete record needs record_id * refactor record parsing * check lowercase fqdn for domain id * avoid connectioninterrupt by filtering possibly empty data * only add name field if not empty * fix ref in record shape returned from dynu * satisfy test that fails when domain not owned * add rudimentary test hooks * remove __class__ ref in favor of self * Add dynu to supported providers * Add record mapping to/from dynu The Dynu API has very specific demands on how records should look like. Where possible, mapping is done in both directions to add support for records other than TXT * Add myself to CODEOWNERS * Update create to conform to spec * Fix mapping to/from dynu api * Add test recordings * Fix failing test * Remove unused import * Fix indentation * Unify logging * final pylint fixes
Bumps [zeep](https://github.com/mvantellingen/python-zeep) from 3.4.0 to 4.0.0. - [Release notes](https://github.com/mvantellingen/python-zeep/releases) - [Changelog](https://github.com/mvantellingen/python-zeep/blob/master/CHANGES) - [Commits](mvantellingen/python-zeep@3.4.0...4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* Added setuptools to requirements in pyproject.toml and blacklisted version 50 due to it breaking install.
Co-authored-by: Takalele <takalele@konnex.me>
Bumps [boto3](https://github.com/boto/boto3) from 1.16.9 to 1.16.17. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.16.9...1.16.17) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [requests](https://github.com/psf/requests) from 2.24.0 to 2.25.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/master/HISTORY.md) - [Commits](psf/requests@v2.24.0...v2.25.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This reverts commit 89d51a3.
Bumps [boto3](https://github.com/boto/boto3) from 1.16.18 to 1.16.20. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.16.18...1.16.20) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This reverts commit 0e2929e.
… paginated in route53 provider. (#679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.