Avoid divide by zero error in coordinated move() #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Division of two floats can be truncated to zero if cast as a long. finalNmberOfSteps is used as a denominator in subsequent calculations. This corrects issue #321.
BarbourSmith
approved these changes
Oct 23, 2017
| @@ -446,7 +446,7 @@ int cordinatedMove(const float& xEnd, const float& yEnd, const float& zEnd, fl | |||
| //compute feed details | |||
| MMPerMin = constrain(MMPerMin, 1, MAXFEED); //constrain the maximum feedrate, 35ipm = 900 mmpm | |||
| float stepSizeMM = computeStepSize(MMPerMin); | |||
| long finalNumberOfSteps = abs(distanceToMoveInMM/stepSizeMM); | |||
|
Great catch! That's a tricky one. This is your second really good tricky bug in a row @blurfl . Awesome job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Division of two floats can be truncated to zero if cast as a long. finalNmberOfSteps is used as a denominator in subsequent calculations.
This corrects issue #321.