B11 should not trigger position error alarm #456
Conversation
The B11 gcode moves a motor at speed S for T seconds. It should not trigger the position error alarm as it is a testing gcode. Usage example (moves the left motor at speed 200 for 2 seconds: B11 L1 S200 T2 (S)peed accepts a float but treats that as an integer 0..255 (T)ime is a float
|
Congratulations on the pull request @blurfl Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged. I'm just a robot, but I love to see people contributing so I'm going vote thumbs up! |
|
Time is up and we're ready to merge this pull request. Great work! |
There was a problem hiding this comment.
Hi,
Sorry to jump into a closed PR, but if you want to clear the bit afterwards, I think this would be better for line 267:
sys.state = (sys.state & (~STATE_POS_ERR_IGNORE));
I mean AND'ing sys.state with all bits except the one to be cleared, and using binary NOT(~) instead of boolean NOT(!).
Unless I'm mistaken.
Regards, S. Peters.
|
That's a good find! A PR to correct that would be great. Very glad to see the details checked, code polished. |
|
Hi,
Thanks for your nice reply!
PR seemed daunting, but I should have managed that by now, back to Git, finally using ssh keys btw.
Now, "my" PR #492 seems to include both the guestbook and the change, we'll see if all goes well.
Regards, --Stephane Peters
|
|
Great to see you @blurfl, we've missed you 😀 |
The B11 gcode moves a motor at speed S for T seconds. It should not trigger the position error alarm as it is a testing gcode.
Usage example (moves the left motor at speed 200 for 2 seconds:
B11 L1 S200 T2
(S)peed accepts a float but treats that as an integer 0..255
(T)ime is a float