Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance nSegment definition to be int or list #133

Closed
j-c-cook opened this issue Aug 9, 2021 · 1 comment
Closed

Enhance nSegment definition to be int or list #133

j-c-cook opened this issue Aug 9, 2021 · 1 comment
Assignees
@j-c-cook
Labels
enhancement

Comments

@j-c-cook
Copy link
Contributor

j-c-cook commented Aug 9, 2021

In every current description of boreSegments in pygfunction, the number of segments is always declared as an integer and a uniform segment length is used across all segments. However, what if a user wants to define a number of segments on a per borehole basis? This issue seeks to address the current inability to define number of segments on a per borehole basis.
@j-c-cook j-c-cook mentioned this issue Aug 9, 2021
Merged
j-c-cook pushed a commit to j-c-cook/pygfunction that referenced this issue Aug 9, 2021
Assert minimum nSegments>=1 when nSegment is list
202c0b0 
related to MassimoCimmino#133
This was referenced Aug 9, 2021
Closed
Merged
@j-c-cook j-c-cook mentioned this issue Aug 10, 2021
Closed
@MassimoCimmino
Copy link
Owner

Solved by #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-c-cook j-c-cook

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MassimoCimmino @j-c-cook