Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of libxml dependency #174

Closed
alecpl opened this issue Nov 20, 2019 · 4 comments · Fixed by #205
Closed

Get rid of libxml dependency #174

alecpl opened this issue Nov 20, 2019 · 4 comments · Fixed by #205

Comments

@alecpl
Copy link
Contributor

alecpl commented Nov 20, 2019

I don't see anything in the code that would require libxml extension. We only need DOM. Do I miss something?

@alecpl
Copy link
Contributor Author

alecpl commented Nov 20, 2019

I see utf8_decode(), but preceded with function_exists() check, so composer.json should not require libxml.

@goetas
Copy link
Member

goetas commented Nov 22, 2019

I think that here the intention was to require ext-dom. Probably is a bug.
(even if having ext-dom implies installing libxml...

I will be happy to change it. Can you reproduce it somehow on travis ci? removing libxml, but keeping extdom?

@alecpl
Copy link
Contributor Author

alecpl commented Nov 25, 2019

No, I didn't try with Travis, that came from one of Roundcube users.

@alecpl
Copy link
Contributor Author

alecpl commented Nov 25, 2019

Actually, the ctype ticket came from the user. This one is from me just reviewing dependencies.

alecpl added a commit to alecpl/html5-php that referenced this issue Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants