Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum PHP requirement to allow more modern code #189

Closed
mundschenk-at opened this issue Jul 1, 2020 · 3 comments
Closed

Increase minimum PHP requirement to allow more modern code #189

mundschenk-at opened this issue Jul 1, 2020 · 3 comments

Comments

@mundschenk-at
Copy link
Contributor

mundschenk-at commented Jul 1, 2020

Currently, library requires PHP 5.3. This should be changed to at least PHP 5.6 to allow the use of more modern language features. Since even PHP 5.6 has not received security updates for more than 18 months, this would not be a radical change.

@goetas
Copy link
Member

goetas commented Jul 2, 2020

I thought in the past about it, but so far there has been not a single feature that required more advances PHP syntax that wasn't available with php 5.3.

I'm willing to increase the version requirements if there will be some feature proposal that will need some of the more recent php features, but I'm not willing to increase the minimum version just for the sake of it.

(as example one large project that uses this library is Roundcube mail, and it requires php 5.4, so increasing too the php requirements will put such project is a difficult situation, and many other project that use this library work in contexes where increasing php version is not an easy thing)

@mundschenk-at
Copy link
Contributor Author

I'm willing to increase the version requirements if there will be some feature proposal that will need some of the more recent php features, but I'm not willing to increase the minimum version just for the sake of it.

5.5 is needed to properly use exceptions (try ... finally). I've linked to the code proposal in question.

(as example one large project that uses this library is Roundcube mail, and it requires php 5.4, so increasing too the php requirements will put such project is a difficult situation, and many other project that use this library work in contexes where increasing php version is not an easy thing)

Well, it's not that previous versions suddenly vanish. Nudging the community to reduce technical debt (by, from time to time, increasing version requirements), is something that I feel large projects have duty to do, to lead by example. Running PHP versions below even 5.6 is irresponsible from a security perspective.

@goetas
Copy link
Member

goetas commented Jul 2, 2020

5.5 is needed to properly use exceptions (try ... finally). I've linked to the code proposal in question.

The code suggested in #187 (comment) does exactly the same without using the finally keyword.

Well, it's not that previous versions suddenly vanish.

They do not vanish, but siad projects will see suddenly disappear the "support" given by this project in providing bugfixes on this library.

I know that the minimumu supported version is a hot topic, In which I believe too. You can see that most of the projects I maintain require at least php 7.2, but this project is particular and used often in contexts where php versions are not that recent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants