Fix travisci build #191
Merged
Fix travisci build #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHPUnit 4.8.35 is quite old and not officially supported on PHP 7. I think you should make the testsuite compatible with newer versions too, letting composer select a good version of PHPUnit for newer runtimes (and maybe bump the minimum PHP versions if needed) |
|
Regarding the minimum version bump there has been a conversation in #189 Having supported multiple php versions would be nice, I hope that someone finds some time to work on it |
|
Well, I think it would still be possible to support PHPUnit 4.8 and newer versions at the same time (maybe using the Symfony PHPUnit bridge to polyfill some APIs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.