Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements with dashes (Web Components support) #65

Closed
wimleers opened this issue Nov 28, 2014 · 3 comments
Closed

Elements with dashes (Web Components support) #65

wimleers opened this issue Nov 28, 2014 · 3 comments

Comments

@wimleers
Copy link

Over at https://www.drupal.org/node/1333730, we're working on pulling in masterminds/html5 via Composer into Drupal 8 core. But we're running into a problem: this library doesn't seem to support elements with dashes.

Elements with dashes are necessary for Web Components support (http://w3c.github.io/webcomponents/spec/custom/). However, technically, the Web Components spec is non-normative (http://www.w3.org/TR/html5/references.html#references), so it's not necessary — strictly speaking.

That being said, I think most people would argue Web Components are clearly going to become an important aspect of web development in the not-too-distant future, and hence we want to make sure Drupal 8 doesn't break them, and hence it'd necessary for this library not to break them, if Drupal 8 wants to use this library.

Would you be willing to add support for Web Components, and hence elements with dashes?

@goetas
Copy link
Member

goetas commented Nov 28, 2014

hi! strange... are you sure? I'm dashes should be allowed. do you have a failing test case?

@filijonka
Copy link

well i''m sure. I did try to add some code here but never posted on github before so assumed that code-tags are allowed but it didn't work properly but read here for an example code: https://www.drupal.org/node/1333730#comment-9387707

@goetas
Copy link
Member

goetas commented Nov 29, 2014

The #66 is intended to fix this. I'm just waiting for a feedback from other collaborators.

@goetas goetas closed this as completed in c158103 Dec 2, 2014
technosophos added a commit that referenced this issue Dec 2, 2014
Added support for dashes in element tag names (closes #65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants