Use mb_substitute_character inset of ini_set #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mundschenk-at
force-pushed
the
ini_set_removal
branch
from
2fd25fd
to
9f3667c
Compare
|
If the mb extension is disabled, will this cause a fatal error? |
|
No, because this code path is only executed when mbstring is enabled. The whole block is wrapped in |
|
In that case, LGTM. I'll merge it. |
technosophos
added a commit
that referenced
this pull request
Mar 19, 2016
Use mb_substitute_character inset of ini_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On shared hosts,
ini_setis often disabled by the administrator. Thembstringextension provides an accessor functionmb_substitute_character, so we should use that instead.